Conversation
Contributor
masakurapa
commented
Feb 16, 2026
masakurapa
commented
- Node.js, pnpmを現時点のLTSに固定しました
Contributor
|
LGTMです！ |
Contributor
|
こちらって、変更の意図としてはCIとローカルの環境を揃えるところですかね？ 特にpnpmのバージョンを完全な固定値にしてしまうと仮想環境用意しなくちゃいけないので少し開発しづらくなりそうだなとも思いました。 もしくはmiseのような仮想環境用の設定が追加できると良いのかなとも思いました |
Contributor
Author
|
そうですねある程度環境は統一したいなとは思っています |
Contributor
Author
|
あーでもこれはあれですねnvmrcでengine-strictを指定しない場合は警告出るくらいなので、大丈夫かも？ |
Contributor
Author
|
Actionsでwarn出てしまうのでマージしてしまいますね!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.