Skip to content

Fix nil panic when kicking a link-dead session at login #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pruuk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix nil panic when kicking a link-dead session at login #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions internal/inputhandlers/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,21 @@ func FinalizeLoginOrCreate(results map[string]string, sharedState map[string]any
userid := users.FindUserId(results["username"])
user := users.GetByUserId(userid)

existingConnectionId := user.ConnectionId()
// The session may have disappeared since the kick prompt (e.g. link-dead
// cleanup), in which case there's nothing to kick. This also covers
// FindUserId returning 0, since GetByUserId(0) returns nil.
if user != nil {

// Send a goodbye message to the currently connected user
tplTxt, _ := templates.Process("goodbye", nil)
connections.SendTo([]byte(templates.AnsiParse(tplTxt)), existingConnectionId)
existingConnectionId := user.ConnectionId()

users.SetLinkDeadUser(userid)
connections.Kick(existingConnectionId, fmt.Sprintf(`Duplicate login (ip: %s)`, connDetails.RemoteAddr()))
// Send a goodbye message to the currently connected user
tplTxt, _ := templates.Process("goodbye", nil)
connections.SendTo([]byte(templates.AnsiParse(tplTxt)), existingConnectionId)

users.SetLinkDeadUser(userid)
connections.Kick(existingConnectionId, fmt.Sprintf(`Duplicate login (ip: %s)`, connDetails.RemoteAddr()))

}

}

Expand Down