Skip to content

Add ItemId and display properties to GMCPRoomModule #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XCH-DEVCI wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ItemId and display properties to GMCPRoomModule #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions modules/gmcp/gmcp.Room.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,12 @@
for _, itm := range room.Items {
payload.Contents.Items = append(payload.Contents.Items, GMCPRoomModule_Payload_Contents_Item{
Id: itm.ShorthandId(),
ItemId: itm.ItemId,
Name: itm.Name(),
SimpleName: itm.NameSimple(),
DisplayName: itm.DisplayName(),
Type: string(spec.Type),

Check failure on line 321 in modules/gmcp/gmcp.Room.go

View workflow job for this annotation

GitHub Actions / Go Tests 

undefined: spec
SubType: string(spec.Subtype),

Check failure on line 322 in modules/gmcp/gmcp.Room.go

View workflow job for this annotation

GitHub Actions / Go Tests 

undefined: spec
QuestFlag: itm.GetSpec().QuestToken != ``,
})
}
Expand Down Expand Up @@ -589,6 +594,11 @@
Id string `json:"id"`
Name string `json:"name"`
QuestFlag bool `json:"quest_flag"`
ItemId int `json:"itemid,omitempty"`
SimpleName string `json:"simple_name,omitempty"`
DisplayName string `json:"display_name,omitempty"`
Type string `json:"type,omitempty"`
SubType string `json:"subtype,omitempty"`
}

type GMCPRoomModule_Payload_Contents_Container struct {
Expand Down
Loading