Skip to content

Add user:// as mod source for 4.x#552

Open
DarthMDev wants to merge 9 commits into
GodotModding:4.x-devfrom
DarthMDev:add-user-mods-4.x
Open

Add user:// as mod source for 4.x#552
DarthMDev wants to merge 9 commits into
GodotModding:4.x-devfrom
DarthMDev:add-user-mods-4.x

Conversation

@DarthMDev
Copy link
Copy Markdown

Fixes #548 (but for 4.x)

@KANAjetzt KANAjetzt added enhancement New feature or request 4.x labels Mar 23, 2025
@KANAjetzt KANAjetzt added this to the 4.x - 7.x milestone Mar 23, 2025
@KANAjetzt KANAjetzt requested review from KANAjetzt and Qubus0 March 23, 2025 20:51
Copy link
Copy Markdown
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick first look. I recommend adding an override option similar to override_path_to_mods.

@export_dir var override_path_to_mods = ""

Thanks for your work and let me know if you get stuck on something :)

@DarthMDev DarthMDev requested a review from KANAjetzt March 24, 2025 08:47
Copy link
Copy Markdown
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you for your contribution 😄 a few naming and docs things, but looks good otherwise. will need to test at a later date

Comment thread addons/mod_loader/internal/path.gd Outdated
Comment thread addons/mod_loader/resources/options_profile.gd Outdated
Comment thread addons/mod_loader/resources/options_profile.gd Outdated
DarthMDev and others added 2 commits March 24, 2025 17:54
@DarthMDev DarthMDev requested a review from Qubus0 March 24, 2025 22:10
Comment thread test/test_options/customize_script/custom_validation.tres Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants