Mac requires 1 more escaped folder to find the workshop contents

[kilian-diener]

Probably same goes for 4.x-dev

[Qubus0]

Which game has this issue? We might need to be more specific than just checking for mac since some steam games don't have the app bundle layer, so this issue does not always exist. We might just have to check both paths

[kilian-diener]

I'm currently setting up a Mac version of Brotato.
The path array is [..., Steam, steamapps, common, Brotato, Brotato.app, ]
With removing 3 entries this results in this workshop path: Steam/steamapps/common/workshop/content/1942280
With removing 4 it resolves correctly to: Steam/steamapps/workshop/content/1942280

I built the game as a ZIP, unpack it and upload the resulting Brotato.app. Maybe it would be different for a .dmg exported game.

[Qubus0]

ah we accounted for that in 4.x with this .app check

godot-mod-loader/addons/mod_loader/internal/path.gd

Lines 22 to 25 in f2d9954

	if OS.get_name() == "macOS":
	game_install_directory = game_install_directory.get_base_dir().get_base_dir()
	if game_install_directory.ends_with(".app"):
	game_install_directory = game_install_directory.get_base_dir()

which is not present in 3.x

godot-mod-loader/addons/mod_loader/internal/path.gd

Lines 17 to 19 in 62a0811

	if OS.get_name() == "OSX":
	game_install_directory = game_install_directory.get_base_dir().get_base_dir()

also hype to hear about brotato for mac 👀

[kilian-diener]

Ah yeah that works as well. However, this may break setups for people using the mods folder without workshop since now the mods folder is expected to be outside the .app folder right? But whatever approach you guys prefer. I'll have it fixed for us anyway.

[Qubus0]

yep, true. most users don't know you can even look inside the .app bundle, so that works 😄 we'll take care of it, thanks for your contribution 👍