fix: Add missing keys in global_script_class_cache_mod_loader.cfg for 4.5.x#576
Merged
Merged
Conversation
KANAjetzt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this solving?
I was not able to setup de mod-loader on a 4.5.x game, and found out why.
This line in the engine makes the combined class cache invalid
https://github.com/godotengine/godot/blob/20430236e749306e1968656ffdc7f78e502a0ccc/core/object/script_language.cpp#L295
It was introduced in version 4.5.1
godotengine/godot@318af42
This PR is the essential modification that I brought to my files to make it work.
I made these change manually, but it work. Maybe load the extension in the editor and copy the new classes? I added
is _toolto class that were having@toolat the top and no abstract classes so it must me okay.Suggestion
GDRE tool version needed to also be bumped, i switched it with version 1.0.2 to make it work. 2.0.0beta8 was also working but while trying to debug i tested multiple version.
The actual version supplied in the release outputted an error saying something like "pack version 3 unsupported" on something like that. ( The current target game was compiled as 4.5 beta2 )