Workaround for Script.get_script_method_list()#594
Open
MSLaFaver wants to merge 2 commits into
Open
Conversation
Qubus0
reviewed
Mar 8, 2026
Collaborator
Qubus0
left a comment
Qubus0
left a comment
There was a problem hiding this comment.
two smaller things, otherwise nice
Author
|
Awesome. I'll make those edits within a few days. Thanks for the comments. |
Author
|
Updated. Please review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered through the process of modding Buckshot Roulette (Godot 4.1.1) that
Script.get_script_method_list()was not returning arguments for any of the functions in specific scripts (e.g.MenuManager.gd). This leftmethod.argscompletely empty for every function parsed withmod_hook_preprocessor.gd. The current usage of this was easily replaceable withmethod_arg_string_with_defaults_and_types, which was just declared on the previous line.This is a quick fix to get the mod loader working for Buckshot, and will likely need a little tweaking to fit in with the existing style.