Conversation
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Removing
CHAIN_OVERRIDESentirely may regress behavior on Celo-like networks that relied on explicit gasPrice/gasLimit (e.g., the previous 1,200,000 gas on approve); consider exposing optional overrides in the SDK methods so callers can still tune gas where needed instead of hardcoding or fully removing this capability. - The new
streamedContributionfield onDonorCollectiveis not yet populated anywhere in the mappings; either wire it up in the relevant handlers or drop it until you are ready to support it to avoid confusion and unused schema surface. - Relaxing
@uniswap/smart-order-routerto"3.*"could silently pull in future breaking changes within major 3; consider pinning to a specific minor/patch or using a caret range you are comfortable with to keep dependency behavior predictable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Removing `CHAIN_OVERRIDES` entirely may regress behavior on Celo-like networks that relied on explicit gasPrice/gasLimit (e.g., the previous 1,200,000 gas on approve); consider exposing optional overrides in the SDK methods so callers can still tune gas where needed instead of hardcoding or fully removing this capability.
- The new `streamedContribution` field on `DonorCollective` is not yet populated anywhere in the mappings; either wire it up in the relevant handlers or drop it until you are ready to support it to avoid confusion and unused schema surface.
- Relaxing `@uniswap/smart-order-router` to `"3.*"` could silently pull in future breaking changes within major 3; consider pinning to a specific minor/patch or using a caret range you are comfortable with to keep dependency behavior predictable.
## Individual Comments
### Comment 1
<location path="packages/subgraph/schema.graphql" line_range="48" />
<code_context>
+ """
+ Number of claims from ubi pools performed
+ """
+ claims: Int!
totalEarned: BigInt!
</code_context>
<issue_to_address>
**suggestion (bug_risk):** New non-null `claims` field on `Steward` requires all mapping code to initialize it for existing and new entities.
Because `claims` is `Int!`, every existing and new `Steward` in the subgraph must have this field set. Any handler that creates or loads a `Steward` needs to initialize `claims` (e.g., default 0) or queries/mappings may fail. Also plan a migration/backfill for already-stored entities before deploying this change to an existing subgraph.
Suggested implementation:
```
events: [SupportEvent!]! @derivedFrom(field: "donorCollective")
"""
Number of actions performed
"""
actions: Int!
"""
Number of claims from ubi pools performed
"""
claims: Int!
totalEarned: BigInt!
```
To fully implement your suggestion about the non-null `claims: Int!` field on `Steward`, the following changes are also required in the mappings (not shown in the snippet):
1. In every handler/factory where a `Steward` is created (e.g., `new Steward(id)`), explicitly initialize `steward.claims = 0` before `steward.save()`.
2. In every handler where a `Steward` might be first loaded and then created if missing (`let steward = Steward.load(id)` pattern), ensure the new entity path also sets `claims = 0`.
3. For existing data in already-deployed subgraphs, implement a backfill/migration strategy:
- Either deploy a temporary version that treats `claims` as nullable, initialize it via handlers (e.g. on next event per Steward) and then migrate to `Int!`, or
- Redeploy from genesis (if feasible) with mappings that initialize `claims = 0` from the start.
4. Update any tests or data fixtures that construct `Steward` entities to include `claims` with a default value of `0`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
L03TJ3
reviewed
Apr 6, 2026
Collaborator
L03TJ3
left a comment
There was a problem hiding this comment.
- By default it now only supplies gasLimit and leaves the rest up to connected wallet to fill in the blanks. Thats as was intended?
…chai matchers import" This reverts commit 1e876cb.
L03TJ3
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Summary by Sourcery
Remove hardcoded gas overrides from GoodCollective SDK transactions and extend subgraph tracking for UBI claims and donor streaming contributions.
Enhancements:
Build: