Skip to content

Goodbridge page#631

Open
Gutopro wants to merge 6 commits intoGoodDollar:masterfrom
Gutopro:goodbridge_page
Open

Goodbridge page#631
Gutopro wants to merge 6 commits intoGoodDollar:masterfrom
Gutopro:goodbridge_page

Conversation

@Gutopro
Copy link
Copy Markdown

@Gutopro Gutopro commented Apr 1, 2026

Description

This PR integrates the MessagePassingBridge

About #628

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Summary by Sourcery

Add a new Good Bridge page integrating the MessagePassingBridge flow and expose it in navigation with feature flag control across supported networks.

New Features:

  • Introduce a Good Bridge page that embeds the MessagePassingBridge controller within the existing PageLayout.
  • Add a Good Bridge navigation entry and route, gated by a dedicated feature flag per network.

Enhancements:

  • Extend feature flag configuration to support enabling or disabling the Good Bridge per supported chain.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new goodBridgeEnabled feature flag is configured in useFeaturesEnabled but not actually used for the sidebar entry or route visibility, so consider wiring it through (similar to microBridgeEnabled) to control when /goodbridge is shown.
  • There is an index.tsx~ file added under src/pages/gd/GoodBridge/ that looks like an editor backup and should probably be removed from the PR.
  • The Good Bridge sidebar item currently reuses the bridgeEnabled condition (!isMinipay || bridgeEnabled), which may be tied to the micro-bridge; consider using a distinct check aligned with goodBridgeEnabled to avoid coupling the two features.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `goodBridgeEnabled` feature flag is configured in `useFeaturesEnabled` but not actually used for the sidebar entry or route visibility, so consider wiring it through (similar to `microBridgeEnabled`) to control when `/goodbridge` is shown.
- There is an `index.tsx~` file added under `src/pages/gd/GoodBridge/` that looks like an editor backup and should probably be removed from the PR.
- The `Good Bridge` sidebar item currently reuses the `bridgeEnabled` condition (`!isMinipay || bridgeEnabled`), which may be tied to the micro-bridge; consider using a distinct check aligned with `goodBridgeEnabled` to avoid coupling the two features.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 1, 2026

hi @L03TJ3 here's the new PR also here's my wallet address
0x8798790bd86170C1F5bF9d681E9038Be94C4B71F

@L03TJ3 L03TJ3 linked an issue Apr 2, 2026 that may be closed by this pull request
10 tasks
@L03TJ3
Copy link
Copy Markdown
Collaborator

L03TJ3 commented Apr 2, 2026

@Gutopro Send you some CELO.
set the bridge to development environment.
you can claim dev G$'s on Celo on: dev.gooddapp.org

That should give you enough to bridge from Celo > Fuse or XDC

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 3, 2026

@Gutopro Send you some CELO. set the bridge to development environment. you can claim dev G$'s on Celo on: dev.gooddapp.org

That should give you enough to bridge from Celo > Fuse or XDC

thanks @L03TJ3 ive seen the Celo, how can i set my bridge to development please?

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 3, 2026

also just a few things

  • i cant claim G$, the facial verification fails with an error saying login information is missing
  • i'm using meta mask, when i connect my wallet to the bridge my balance isnt reflected on the page but the wallet connects successfully.
image image

@L03TJ3

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 6, 2026

Hi @L03TJ3 any updates on this?

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 7, 2026

@L03TJ3 it's been awhile and I haven't gotten any feedback from you

@L03TJ3
Copy link
Copy Markdown
Collaborator

L03TJ3 commented Apr 7, 2026

Up for review today, weekend in the middle

@L03TJ3
Copy link
Copy Markdown
Collaborator

L03TJ3 commented Apr 7, 2026

@Gutopro

  1. make sure to initially claim the dev G$'s on https://dev.gooddapp.org
  2. locally you will have to setup the .env file and if you followed this instructions: Feat: integrate the MessagePassingBridge #628 (comment)
    your local dapp should already be set up to the development-environment.

If you have not been able to claim dev G$'s, what would you expect your balance to show/be?

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 7, 2026

I tried claiming the G$ but the verification keeps failing just like in the screenshot I shared earlier

@L03TJ3
Copy link
Copy Markdown
Collaborator

L03TJ3 commented Apr 7, 2026

@Gutopro I just tried and it worked, I don't get the 'information missing' screen.
so you'll need to provide a bit more details so I can assist better.
what can also help is a video demonstrating the flow and issue

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 7, 2026

here's a link to the video on loom.
https://www.loom.com/share/23046953a3ca4ac8b3a7a78834b2c1c2

initially the facial verification wouldnt work but on this try it did, then it failed at the location verification as seen in the video, i'm not using any vpn so i wonder why it wouldnt work.
@L03TJ3

@L03TJ3
Copy link
Copy Markdown
Collaborator

L03TJ3 commented Apr 7, 2026

@Gutopro Okay, confirmed the bug on my side too. I have disabled this flow now. if you clear your cache/hard refresh the claim page you should be able to claim

@Gutopro
Copy link
Copy Markdown
Author

Gutopro commented Apr 7, 2026

thank you. i was able to get the G$. i made a test video demonstrating my progress with the page so far and this is what i have
https://www.loom.com/share/c662ff9ee30440d48071a8ddfe784293
@L03TJ3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: integrate the MessagePassingBridge

2 participants