Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The change to always delete
params[0].gasPricefor chains present ingasSettingsalters previous behavior wheregasPricewas preserved if amaxFeePerGaswas already provided or on chain 50; confirm that removing this distinction is intentional and won’t break callers relying on explicitgasPrice. - Since chain 42220 is no longer in
gasSettings, consider also removing any now-dead logic or assumptions elsewhere that might still treat 42220 as having forced EIP-1559-style fees.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change to always delete `params[0].gasPrice` for chains present in `gasSettings` alters previous behavior where `gasPrice` was preserved if a `maxFeePerGas` was already provided or on chain 50; confirm that removing this distinction is intentional and won’t break callers relying on explicit `gasPrice`.
- Since chain 42220 is no longer in `gasSettings`, consider also removing any now-dead logic or assumptions elsewhere that might still treat 42220 as having forced EIP-1559-style fees.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
L03TJ3
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: