Skip to content

fix: stop forcing celo gas price#632

Merged
L03TJ3 merged 2 commits intomasterfrom
fix/celo-new-gas-pricing
Apr 6, 2026
Merged

fix: stop forcing celo gas price#632
L03TJ3 merged 2 commits intomasterfrom
fix/celo-new-gas-pricing

Conversation

@sirpy
Copy link
Copy Markdown
Contributor

@sirpy sirpy commented Apr 5, 2026

Summary by Sourcery

Bug Fixes:

  • Stop forcing a fixed gas price configuration for the Celo network to allow the provider to use dynamic gas pricing.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The change to always delete params[0].gasPrice for chains present in gasSettings alters previous behavior where gasPrice was preserved if a maxFeePerGas was already provided or on chain 50; confirm that removing this distinction is intentional and won’t break callers relying on explicit gasPrice.
  • Since chain 42220 is no longer in gasSettings, consider also removing any now-dead logic or assumptions elsewhere that might still treat 42220 as having forced EIP-1559-style fees.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The change to always delete `params[0].gasPrice` for chains present in `gasSettings` alters previous behavior where `gasPrice` was preserved if a `maxFeePerGas` was already provided or on chain 50; confirm that removing this distinction is intentional and won’t break callers relying on explicit `gasPrice`.
- Since chain 42220 is no longer in `gasSettings`, consider also removing any now-dead logic or assumptions elsewhere that might still treat 42220 as having forced EIP-1559-style fees.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 5, 2026

Deploying goodprotocolui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5069f4a
Status:⚡️  Build in progress...

View logs

@L03TJ3 L03TJ3 merged commit 75119f4 into master Apr 6, 2026
5 of 6 checks passed
@L03TJ3 L03TJ3 deleted the fix/celo-new-gas-pricing branch April 6, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants