feat: Update sample project to use newest coordinator version#15
Open
matusklasovity wants to merge 1 commit intomainfrom
Open
feat: Update sample project to use newest coordinator version#15matusklasovity wants to merge 1 commit intomainfrom
matusklasovity wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sample project to use the latest GoodCoordinator-iOS (v3.1.0) dependency.
- Bumps the SPM package revision and version in
Package.resolved - Updates the
minimumVersionrequirement inproject.pbxproj
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| GoodReactor-Sample/GoodReactor-Sample.xcodeproj/.../Package.resolved | Updated GoodCoordinator-iOS dependency revision and version to 3.1.0 |
| GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.pbxproj | Updated SPM minimumVersion requirement for GoodCoordinator-iOS to 3.1.0 |
Comments suppressed due to low confidence (2)
GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved:19
- Update the sample project's README or documentation to mention GoodCoordinator-iOS v3.1.0 so users are aware of the new version requirement.
"version" : "3.1.0"
GoodReactor-Sample/GoodReactor-Sample.xcodeproj/project.pbxproj:676
- Add or update integration/CI tests to verify that the sample project builds and functions correctly with GoodCoordinator-iOS v3.1.0.
minimumVersion = 3.1.0;
matusklasovity
force-pushed
the
feature/update-sample
branch
from
701250b to
4a231b9
Compare
plajdo
approved these changes
Jun 23, 2025
Contributor
|
@matusklasovity pozri prosim, ci toto bude fungovat po mergnuti #16, kedze tam sa coordinatory presuvali do samostatnej kniznice. Mozno bude treba updatnut aj projektovy template, once again 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.