Update lock file (npm audit fix)#3510
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For release preparation.
Updates a test as well:
After running npm audit fix , the following key dependencies were updated:
• webpack from 5.95.0 to 5.106.2
• terser-webpack-plugin from 5.3.10 to 5.5.0
• terser from 5.30.3 to 5.46.2
In the failing test should produce valid JavaScript when eval-cheap-source-map and minimization are used , devtool is set to eval-cheap-source-map and minimize
is
true . Under this setting, modules are bundled and wrapped in eval("...") statements.
Previously, the compilation produced 4 files:
However, in the newer version of Terser / terser-webpack-plugin , the comments inside the eval(...) strings are correctly ignored during comment extraction (since
they
are inside a string literal rather than top-level code comments in the chunk). Consequently, webpackEntry.js.LICENSE.txt is no longer created, resulting in exactly 3
files.
This is standard, correct, and expected behavior for the updated webpack and terser versions.
The Solution
I updated the assertion in the test suite under inject-manifest.js#L825-L830 to reflect the correct file count: