fix(dashboard): harden BigQuery connector for PR #142#144
Closed
caohy1988 wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reference implementation for the data connector fixes discussed on #142.
PR #142 adds
dashboard_v2/and the Vercel dashboard shell, but the current/apiBigQuery connector has three practical issues:credentialsobject whenGCP_CLIENT_EMAIL/GCP_PRIVATE_KEYare absent, which breaks local ADC /GOOGLE_APPLICATION_CREDENTIALSsetups;agent_eventsrows even though the UI expects graph-friendly fields likeid,parent_id,type,label,latency, andtotal_tokens.I could not push directly to Saherpathan's PR branch, so this draft PR shows the concrete patch for the author to cherry-pick or copy.
What
dashboard_v2/api/index.ts:GOOGLE_APPLICATION_CREDENTIALS;dashboard_v2/src/services/apiService.tsto URL-encode the timespan value.npx vercel dev, not bare Vite;npm startscript (server.cjsdoes not exist) withvite preview --host=0.0.0.0.Verification
Run from
dashboard_v2/:npm ci-> clean, 0 vulnerabilitiesnpm run lint-> clean (tsc --noEmit)npm run build-> clean; Vite emits only the existing large-chunk warninggit diff --check-> cleanNotes
This is intentionally marked draft because it is a reference patch for #142, not a competing dashboard submission. The preferred path is for #142's author to incorporate these connector changes into their branch.