Skip to content

[StepSecurity] ci: Harden GitHub Actions#3888

Merged
derrickaw merged 1 commit into
GoogleCloudPlatform:mainfrom
step-security-bot:chore/GHA-041552-stepsecurity-remediation
Jun 4, 2026
Merged

[StepSecurity] ci: Harden GitHub Actions#3888
derrickaw merged 1 commit into
GoogleCloudPlatform:mainfrom
step-security-bot:chore/GHA-041552-stepsecurity-remediation

Conversation

@step-security-bot
Copy link
Copy Markdown
Contributor

Summary

This pull request is created by StepSecurity at the request of @derrickaw. Please merge the Pull Request to incorporate the requested changes. Please tag @derrickaw on your message if you have any questions related to the PR.

Security Fixes

Pinned Dependencies

GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the security posture of the repository's CI/CD workflows by transitioning from mutable action tags to immutable commit SHAs. This change ensures that the pipeline executes a verified version of the action, protecting the build process from unexpected upstream modifications.

Highlights

  • Security Hardening: Pinned the actions/upload-artifact GitHub Action to a specific commit SHA to ensure build integrity and prevent potential supply chain vulnerabilities.
Ignored Files
  • Ignored by pattern: .github/workflows/** (20)
    • .github/workflows/bigtable-pr.yml
    • .github/workflows/bqmonitor-pr.yml
    • .github/workflows/cleanup-spanner-test-infra.yml
    • .github/workflows/datastream-pr.yml
    • .github/workflows/java-pr.yml
    • .github/workflows/kafka-pr.yml
    • .github/workflows/label-dependabot-prs.yml
    • .github/workflows/load-tests.yml
    • .github/workflows/run-it-tests-beam-snapshots.yml
    • .github/workflows/spanner-failure-injection-tests.yml
    • .github/workflows/spanner-load-tests.yml
    • .github/workflows/spanner-pr.yml
    • .github/workflows/spanner-staging-tests.yml
    • .github/workflows/spanner-terraform-validator.yml
    • .github/workflows/stale.yml
    • .github/workflows/update-docs.yml
    • .github/workflows/update-python-deps.yml
    • .github/workflows/upload-jar.yml
    • .github/workflows/upload-python-package.yml
    • .github/workflows/yaml-pr.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GitHub Action publish-site-report to pin the actions/upload-artifact action to a specific commit SHA (ea165f8d65b6e75b540449e92b4886f43607fa02) for improved security and reproducibility. There are no review comments, and I have no feedback to provide.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.54%. Comparing base (d2ed574) to head (ff8d105).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3888      +/-   ##
============================================
- Coverage     55.55%   55.54%   -0.01%     
+ Complexity     7026     7023       -3     
============================================
  Files          1103     1103              
  Lines         67573    67573              
  Branches       7581     7581              
============================================
- Hits          37537    37531       -6     
- Misses        27621    27626       +5     
- Partials       2415     2416       +1     
Components Coverage Δ
spanner-templates 88.31% <ø> (ø)
spanner-import-export 68.65% <ø> (-0.02%) ⬇️
spanner-live-forward-migration 90.21% <ø> (ø)
spanner-live-reverse-replication 83.96% <ø> (ø)
spanner-bulk-migration 92.61% <ø> (ø)
gcs-spanner-dv 88.99% <ø> (ø)
see 4 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw added the improvement Making existing code better label Jun 4, 2026
@derrickaw
Copy link
Copy Markdown
Contributor

R: @Abacn

Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

Please follow up with test breakage if any.

There was back-of-forth moving from/to SHA and un-pinned version:

https://github.com/step-security-bot/DataflowTemplates/commits/main/.github/actions/publish-site-report/action.yml

each choice has its prod/cons. Pinned version will break when its decommissioned

@derrickaw
Copy link
Copy Markdown
Contributor

Thanks, lgtm

Please follow up with test breakage if any.

There was back-of-forth moving from/to SHA and un-pinned version:

https://github.com/step-security-bot/DataflowTemplates/commits/main/.github/actions/publish-site-report/action.yml

each choice has its prod/cons. Pinned version will break when its decommissioned

ack

@derrickaw derrickaw merged commit 9c5965d into GoogleCloudPlatform:main Jun 4, 2026
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants