Conversation
| "I", # isort | ||
| "ANN", # flake8-annotations | ||
| ] | ||
| ignore = [ |
Collaborator
There was a problem hiding this comment.
Why did we decide to ignore these? Can we add a comment here explaining the reason?
Member
Author
There was a problem hiding this comment.
We were implicitly depending on these rules. Now that ruff is in, I think we should delete the ignore list and just default to whatever the standard list is. I'll send a follow-up PR for that.
Member
Author
There was a problem hiding this comment.
See #542 where I've removed these rules (and the linter is now complaining). I think we can fix all these problems and have a cleaner code base as a result.
rhatgadkar-goog
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443.