Update sql guide#222
Open
cpcgoogle wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Bigtable SQL guide to recommend using SQL functions for data manipulation before implementing custom client-side logic, and adds a link to the application development guide. The reviewer suggested fixing a double-space typo and using more descriptive link text to improve accessibility and readability.
| ### Functions and operators | ||
|
|
||
| Bigtable offers a wide range of [SQL functions](https://docs.cloud.google.com/bigtable/docs/reference/sql/functions-all) and [operators](https://docs.cloud.google.com/bigtable/docs/reference/sql/operators) and [conditional expressions](https://docs.cloud.google.com/bigtable/docs/reference/sql/conditional_expressions). | ||
| Bigtable offers a wide range of [SQL functions](https://docs.cloud.google.com/bigtable/docs/reference/sql/functions-all) and [operators](https://docs.cloud.google.com/bigtable/docs/reference/sql/operators) and [conditional expressions](https://docs.cloud.google.com/bigtable/docs/reference/sql/conditional_expressions). When developing an application using Bigtable, you should always consider if the data manipulation can be performed using a SQL function before trying to develop the logic in the client application. For best practices on using Bigtable SQL from an application, see this [guide](https://docs.cloud.google.com/bigtable/docs/googlesql-develop-apps) that explains how to create the client, prepare the query, and read the results. |
Contributor
There was a problem hiding this comment.
There is a double space in on using. Additionally, using "this [guide]" as link text is less descriptive. It is better to use more descriptive link text for improved readability and accessibility.
Suggested change
| Bigtable offers a wide range of [SQL functions](https://docs.cloud.google.com/bigtable/docs/reference/sql/functions-all) and [operators](https://docs.cloud.google.com/bigtable/docs/reference/sql/operators) and [conditional expressions](https://docs.cloud.google.com/bigtable/docs/reference/sql/conditional_expressions). When developing an application using Bigtable, you should always consider if the data manipulation can be performed using a SQL function before trying to develop the logic in the client application. For best practices on using Bigtable SQL from an application, see this [guide](https://docs.cloud.google.com/bigtable/docs/googlesql-develop-apps) that explains how to create the client, prepare the query, and read the results. | |
| Bigtable offers a wide range of [SQL functions](https://docs.cloud.google.com/bigtable/docs/reference/sql/functions-all) and [operators](https://docs.cloud.google.com/bigtable/docs/reference/sql/operators) and [conditional expressions](https://docs.cloud.google.com/bigtable/docs/reference/sql/conditional_expressions). When developing an application using Bigtable, you should always consider if the data manipulation can be performed using a SQL function before trying to develop the logic in the client application. For best practices on using Bigtable SQL from an application, see the [guide on developing applications with GoogleSQL](https://docs.cloud.google.com/bigtable/docs/googlesql-develop-apps) that explains how to create the client, prepare the query, and read the results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a reference to the SQL for application best practices documentation.