chore(deps): update dependency nokogiri to v1.19.1 [security]

[renovate-bot]

This PR contains the following updates:

Package	Change	Age	Confidence
nokogiri	1.18.9 → 1.19.1

GitHub Vulnerability Alerts

GHSA-wx95-c6cv-8532

Summary

Nokogiri's CRuby extension fails to check the return value from xmlC14NExecute in the method Nokogiri::XML::Document#canonicalize and Nokogiri::XML::Node#canonicalize. When canonicalization fails, an empty string is returned instead of raising an exception. This incorrect return value may allow downstream libraries to accept invalid or incomplete canonicalized XML, which has been demonstrated to enable signature validation bypass in SAML libraries.

JRuby is not affected, as the Java implementation correctly raises RuntimeError on canonicalization failure.

Mitigation

Upgrade to Nokogiri >= 1.19.1.

Severity

The maintainers have assessed this as Medium severity. Nokogiri itself is a parsing library without a clear security boundary related to canonicalization, so the direct impact is that a method returns incorrect data on invalid input. However, this behavior was exploited in practice to bypass SAML signature validation in downstream libraries (see References).

Credit

This vulnerability was responsibly reported by HackerOne researcher d4d.

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[dpebot]

/gcbrun

[gemini-code-assist]

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request upgrades the nokogiri gem to mitigate a security vulnerability. The update ensures that the application uses a patched version of the library, preventing potential issues related to XML canonicalization and SAML signature validation bypasses.

Highlights

• Dependency Update: Updated the nokogiri gem from version 1.18.9 to 1.19.1.
• Security Fix: This update addresses a medium-severity vulnerability (GHSA-wx95-c6cv-8532) in nokogiri that could lead to SAML signature validation bypass due to incorrect handling of XML canonicalization failures.

Changelog

• infra/build/developer-tools/build/data/Gemfile.lock
  • Updated nokogiri dependency from 1.18.9 to 1.19.1.

Activity

• This pull request was automatically generated by Renovate Bot to update the nokogiri dependency.
• Automerge is currently disabled, requiring manual merging.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the nokogiri dependency to version 1.19.1, addressing a medium-severity security vulnerability (GHSA-wx95-c6cv-8532). The change in Gemfile.lock is correct. However, I've identified a potential issue where the Gemfile is not updated accordingly. My review includes a recommendation to update the Gemfile to enforce the use of the patched version of nokogiri, preventing accidental installations of vulnerable versions in the future.

[gemini-code-assist]

This update to nokogiri to version 1.19.1 patches a security vulnerability. However, the corresponding Gemfile still specifies ~> 1.18, which allows versions older than 1.19.1 that are vulnerable.

If the Gemfile.lock were to be removed or regenerated, a vulnerable version of nokogiri could be installed.

To prevent this, I recommend updating line 19 of infra/build/developer-tools/build/data/Gemfile to require at least the patched version.

From:

gem 'nokogiri', '~> 1.18'

To:

gem 'nokogiri', '~> 1.19', '>= 1.19.1'

This will ensure that only versions >= 1.19.1 and < 2.0 are installed, which includes the security fix and allows for future minor and patch releases within the 1.x series.

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun

[dpebot]

/gcbrun