fix(okf): align required frontmatter keys with OKF SPEC §4.1#145
Open
passionworkeer wants to merge 1 commit into
Open
fix(okf): align required frontmatter keys with OKF SPEC §4.1#145passionworkeer wants to merge 1 commit into
passionworkeer wants to merge 1 commit into
Conversation
OKF v0.1 §4.1 explicitly states that only `type` is REQUIRED; `title`, `description`, and `timestamp` are listed as Recommended. The reference implementation treated all four as REQUIRED, so any spec-minimal bundle whose concepts only declared `type` would be incorrectly rejected by OKFDocument.validate(). This hurts programmatic producers in particular — they often have no human-readable title/description available at generation time. This PR is a rebase of upstream GoogleCloudPlatform#64 onto the post-GoogleCloudPlatform#129 `enrichment_agent` → `reference_agent` rename: change one constant, update the corresponding test, and add a minimal-frontmatter acceptance test.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OKF v0.1 §4.1 explicitly states that only
typeis REQUIRED;title,description, andtimestampare listed as Recommended. The referenceimplementation treated all four as REQUIRED, so any spec-minimal bundle
whose concepts only declared
typewould be incorrectly rejected byOKFDocument.validate().This hurts programmatic producers in particular — they often have no
human-readable
title/descriptionavailable at generation time.