Skip to content

networkservices: added allow_global_access to google_network_services_gateway#18332

Open
ashishch432 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ashishch432:add-networkservices-gateway-allowglobalaccess
Open

networkservices: added allow_global_access to google_network_services_gateway#18332
ashishch432 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ashishch432:add-networkservices-gateway-allowglobalaccess

Conversation

@ashishch432

Copy link
Copy Markdown

Adds the allow_global_access field to the google_network_services_gateway resource.
As noted in GCP Console and observed via testing, this field cannot be updated in-place on the SECURE_WEB_GATEWAY proxy after creation. Thus, it is marked as immutable so Terraform can correctly handle updates by recreating the resource.

networkservices: added `allow_global_access` field to `google_network_services_gateway`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 20, 2026
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from shuyama1 July 20, 2026 08:35
@modular-magician modular-magician added service/networkservices-traffic-director and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 21, 2026
@modular-magician

modular-magician commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0dbff63:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 191 insertions(+)
google-beta provider View Diff 4 files changed, 191 insertions(+)
terraform-google-conversion View Diff 5 files changed, 36 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
102 99 2 1
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesGateway_swpAllowGlobalAccess

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccNetworkServicesGateway_swpAllowGlobalAccess

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@ashishch432, @shuyama1 VCR tests complete for 0dbff63!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants