Open
Conversation
# Conflicts: # project.yaml # submodules/fluent-bit # transformation_test/transformation_test.go
Contributor
LujieDuan
changed the title
LujieDuan
reviewed
Mar 24, 2026
|
|
||
| %pre | ||
| %if 0%{?suse_version} >= 1600 | ||
| %systemd_pre google-cloud-ops-agent.service |
Contributor
There was a problem hiding this comment.
LujieDuan
reviewed
Mar 24, 2026
pkg/rpm/build.sh
Outdated
| # Build .rpms | ||
| RPMBUILD_ARGS=() | ||
| if [[ -n "${SLE_VERSION}" ]]; then | ||
| RPMBUILD_ARGS+=(--define "sle_version ${SLE_VERSION}") |
Contributor
There was a problem hiding this comment.
We need {sle_version} in pkg/rpm/google-cloud-ops-agent.spec, but for our building image OpenSUSE 16, this does not exist, so we need to pass this explicitly.
On OpenSUSE 16:
$ rpm --eval '%{sle_version}'
%{sle_version}
$ rpm --eval '%{suse_version}'
1600
This reverts commit 40f761b.
Contributor
|
RPM distros integration tests are passing (SLES 15 is actually SLES 16 here): |
Contributor
|
SLES 15 tests passed - reverting the temporary changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the build configuration for SLES 16.
Related issue
b/460262238
How has this been tested?
Follow the new distro guide - borrowed SLES 15's config to run integration tests. All Ops Agent integration tests passed and then reverted the temporary changes.
Checklist: