Enable OTel Logging for unmodified default pipelines#2239
Open
quentinmit wants to merge 10 commits intomasterfrom
Open
Enable OTel Logging for unmodified default pipelines#2239quentinmit wants to merge 10 commits intomasterfrom
quentinmit wants to merge 10 commits intomasterfrom
Conversation
…dified from the default and the user doesn't opt out
braydonk
approved these changes
Mar 27, 2026
| } | ||
| gceMetadataAttributesProcessors, err := addGceMetadataAttributesProcessor(ctx).Processors(ctx) | ||
| if err != nil { | ||
| panic("Failed to generate static ModifyFields") |
Contributor
There was a problem hiding this comment.
Should we be surfacing the error here? Just wondering why the generic panic rather than returning the error or formatting the error into the panic.
| platformDefaultConfig := BuiltInConfStructs[platform.FromContext(ctx).Name()].Logging | ||
| exp_otlp := experimentsFromContext(ctx)["otlp_logging"] | ||
| exp_otel := l.Service.OTelLogging | ||
| // N.B. Temporarily gate the "auto" otel logging behind an experiment flag. |
Contributor
There was a problem hiding this comment.
What does N.B. stand for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use OTel Logging for
default_pipelineiff the default pipeline has not been modified and the user does not specifyexperimental_otel_logging: false.Related issue
b/494017653
How has this been tested?
Integration tests and new confgenerator test
Checklist: