feat: disable described statement cache timeout by default#4409
Open
olavloite wants to merge 2 commits intopostgresql-dialectfrom
Open
feat: disable described statement cache timeout by default#4409olavloite wants to merge 2 commits intopostgresql-dialectfrom
olavloite wants to merge 2 commits intopostgresql-dialectfrom
Conversation
The timeout for the described statements cache was set to 30 minutes by default. This default is now set to Long.MAX_VALUE, as elements in this cache are (almost) never invalidated. They would only be invalidated if the data type of an existing column would change while the application is running, which is a very rare event. The added number of roundtrips that are added by invalidating elements in this cache once every 30 minutes does not weigh up against the tiny probability that any elements are actually invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeout for the described statements cache was set to 30 minutes by default. This default is now set to Long.MAX_VALUE, as elements in this cache are (almost) never invalidated. They would only be invalidated if the data type of an existing column would change while the application is running, which is a very rare event. The added number of roundtrips that are added by invalidating elements in this cache once every 30 minutes does not weigh up against the tiny probability that any elements are actually invalid.