Skip to content

chore(multiple samples): Update requests dependencies#14386

Draft
XrossFox wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-missing-requests
Draft

chore(multiple samples): Update requests dependencies#14386
XrossFox wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
XrossFox:package-update-missing-requests

Conversation

@XrossFox

@XrossFox XrossFox commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

To fix dependabot security alerts:

  • Regenerated requirements.txt in dataflow/flex-templates/pipeline_with_dependencies using pip-compile to update dependencies for Python 3.13 and a new package index.
  • Removed pytest version constraint in requirements-test.txt.

Note: this re-generation of requirements file, also fixes alerts for urllib3.

Fixes b/531833198

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

 - Regenerated `requirements.txt` in `dataflow/flex-templates/pipeline_with_dependencies` using pip-compile to update
     dependencies for Python 3.13 and a new package index.
 - Removed pytest version constraint in `requirements-test.txt`.
 - Bumped `requests` to 2.34.2 in `run/mcp-server/uv.lock`.
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. labels Jul 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency requirements, including upgrading the autogeneration Python version to 3.13 and bumping several package versions such as apache-beam[gcp] and requests. A critical issue was identified in requirements.txt where a staging Artifact Registry index URL was committed; this private URL must be removed to prevent installation failures for external users.

# pip-compile --output-file=requirements.txt pyproject.toml
#
apache-beam[gcp]==2.54.0
--index-url https://us-python.pkg.dev/artifact-foundry-prod/ah-3p-staging-python/simple/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The staging Artifact Registry index URL (https://us-python.pkg.dev/artifact-foundry-prod/ah-3p-staging-python/simple/) should not be committed to a public repository. External users will not have access to this private/staging registry, which will cause pip install to fail. Please remove this --index-url line so that packages are resolved from the standard public PyPI index.

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants