This repository was archived by the owner on Jan 4, 2023. It is now read-only.
Basic error handling in watch_topic.#12
Open
kir-titievsky wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
Basic error handling in watch_topic.#12kir-titievsky wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
kir-titievsky wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
jpatokal
reviewed
Mar 12, 2019
| if (msgs != None): | ||
| self.process_messages(msgs) | ||
| else: | ||
| log.error('Skipping processing message.') |
Member
There was a problem hiding this comment.
Not having any messages should not raise errors?
Member
|
Thanks for the PR and apologies for the slow response, I've only recently taken over this repo. Please see my comment if you're still keen to push this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider adding basic error handling to the code to avoid crashes in long-running jobs.