fix(ci): add missing !no_sqlite build tag to signing_key_shared_test.go#334
Merged
Merged
Conversation
signing_key_shared_test.go calls newTestStore() which is only defined in files gated by //go:build !no_sqlite, causing "undefined: newTestStore" when CI runs go vet -tags no_sqlite.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a //go:build !no_sqlite build constraint to pkg/hub/signing_key_shared_test.go to prevent it from being compiled when SQLite is disabled. There are no review comments, and I have no additional feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signing_key_shared_test.go(introduced in PR 328) callsnewTestStore()which is only defined in!no_sqlite-gated files//go:build !no_sqlitetag causesgo vet -tags no_sqliteto fail withundefined: newTestStorecommand_bus_test.goandbroker_affinity_test.goTest plan
go vet -tags no_sqlite ./pkg/hub/...passesgofmt -l .returns no files