Conversation
Merged
There was a problem hiding this comment.
Pull request overview
This PR introduces Koin-based wiring so the glue module can obtain the app’s MainActivity class without using reflection (Class.forName(...)), aligning with the ongoing module separation work (refs PR #180).
Changes:
- Add Koin dependencies (BOM + core/android) and apply a Koin compiler Gradle plugin in the app module.
- Start Koin in
MainApplicationand register anappModulethat providesMainActivityClassProvider. - Update
glue’smainIntent()helper to resolve the target activity class via Koin instead of reflection.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
gradle/libs.versions.toml |
Adds Koin BOM/libs and a Koin compiler plugin entry to the version catalog. |
glue/src/main/kotlin/com/github/kr328/clash/util/Intent.kt |
Replaces reflection with a Koin-provided MainActivity class for mainIntent(). |
glue/build.gradle.kts |
Adds Koin BOM + core dependency to support the new mainIntent() implementation. |
app/src/main/kotlin/com/github/kr328/clash/MainApplication.kt |
Starts Koin at app startup and installs the app module. |
app/src/main/kotlin/com/github/kr328/clash/AppModule.kt |
Defines a Koin module providing MainActivityClassProvider. |
app/build.gradle.kts |
Applies the Koin compiler plugin and adds Koin Android dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs