Skip to content

Add attendance history in shift details modal#303

Open
SanjayaGrg wants to merge 2 commits intomainfrom
SanjayaGrg/feature/add-attendance-history-shift-detail-modal
Open

Add attendance history in shift details modal#303
SanjayaGrg wants to merge 2 commits intomainfrom
SanjayaGrg/feature/add-attendance-history-shift-detail-modal

Conversation

@SanjayaGrg
Copy link
Copy Markdown
Collaborator

Summary

This PR adds attendance history display in the shift detail screen and shift detail modal.

Changes made

  • added local attendance history display in ShiftDetailsScreen
  • added local attendance history display in ShiftDetailsModal
  • used AsyncStorage attendance data based on shift id
  • kept attendance data available even when shift status changes
  • added fallback local check-in/check-out handling while backend attendance API is not ready

Notes

  • attendance is currently shown from local storage only
  • backend attendance API is not used yet
  • this is temporary until attendance endpoints are ready
image

Testing

  • checked in locally and confirmed check-in time is saved
  • opened shift details screen and verified attendance history is shown
  • opened shift details modal and verified attendance history is shown there too
  • confirmed attendance still shows when the same shift moves by status and keeps the same id

Screenshots

image

@Krisha190235
Copy link
Copy Markdown
Collaborator

Thanks for adding the attendance history — this looks useful.

Just a note: the check-in/check-out issue has already been resolved, so we shouldn’t be modifying or commenting out that logic in this PR.

Could you please:

  • Revert any changes related to check-in/check-out
  • Keep this PR focused only on displaying the attendance history in the shift details screen/modal

check-in/check-out issue is already been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants