fix(eslint): resolve react-hooks state and purity warnings#366
Merged
TeddyScript101 merged 1 commit intomainfrom May 10, 2026
Merged
fix(eslint): resolve react-hooks state and purity warnings#366TeddyScript101 merged 1 commit intomainfrom
TeddyScript101 merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActiveSOSScreen.tsx: Fixed the react-hooks/purity violation. Date.now() is no longer called synchronously inside useRef(). It is now lazily initialized using useState(() => Date.now()) to guarantee it only evaluates once upon mount and avoids triggering impure rendering warnings.
EditProfileScreen.tsx: Resolved the react-hooks/set-state-in-effect violation. State variables such as formData and licenseImage are now directly initialized with route.params in their useState declarations, eliminating the need to synchronise them inside a useEffect.
ProfileScreen.tsx & EditProfileScreen.tsx: Addressed warnings regarding calling async data-fetching functions that contain synchronous setState updates directly within the effect body. The logic is now correctly enclosed within an async IIFE (async () => { ... }) inside the useEffect hooks.