fix(#3654): modal border removal, status close button hover colors#3798
Merged
ArakTaiRoth merged 1 commit intodevfrom Apr 28, 2026
Merged
fix(#3654): modal border removal, status close button hover colors#3798ArakTaiRoth merged 1 commit intodevfrom
ArakTaiRoth merged 1 commit intodevfrom
Conversation
✅ Deploy Preview for benji-docs-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
twjeffery
force-pushed
the
tom/modal-refinements
branch
from
25389e6 to
a305f9a
Compare
Collaborator
Author
Design token dependenciesThis PR has inline token overrides in
|
ArakTaiRoth
reviewed
Apr 14, 2026
twjeffery
force-pushed
the
tom/modal-refinements
branch
from
a305f9a to
eeb1310
Compare
Spark450
reviewed
Apr 14, 2026
Collaborator
Spark450
left a comment
Spark450
left a comment
There was a problem hiding this comment.
Just that one recommendation for the docs site. The changes to the component look good to me
twjeffery
force-pushed
the
tom/modal-refinements
branch
from
eeb1310 to
b11423a
Compare
Spark450
approved these changes
Apr 15, 2026
Collaborator
Spark450
left a comment
Spark450
left a comment
There was a problem hiding this comment.
Docs comment addressed.
…ndocument event variant Remove visible border from V2 modal surface. Add per-status hover background colors on the close icon button for callout modals (information, success, important, emergency), matching the notification banner low emphasis pattern. Remove event callout variant from docs configurations. Inline tokens are temporary, pending design-tokens PR.
twjeffery
force-pushed
the
tom/modal-refinements
branch
from
b11423a to
47d5050
Compare
|
Preview removedAll preview folders cleaned from gh-pages branch. |
ArakTaiRoth
approved these changes
Apr 28, 2026
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--goa-modal-border, a greyscale-150 solid border)Note: Close button hover tokens are defined inline in Modal.svelte temporarily. A follow-up design-tokens PR will add proper
modal-callout-*-close-bg-hovertokens, and that PR will also fix a pre-existing bug where the notification banner important high/low close hover colors are swapped.Fixes #3654
Steps needed to test
npm run serve:prs:react)