Skip to content

fix(#3648): remove edge treatment from high emphasis badges#3801

Merged
ArakTaiRoth merged 1 commit intodevfrom
tom/badge-refinements
Apr 28, 2026
Merged

fix(#3648): remove edge treatment from high emphasis badges#3801
ArakTaiRoth merged 1 commit intodevfrom
tom/badge-refinements

Conversation

@twjeffery
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery commented Apr 10, 2026

Summary

  • Remove the inner box-shadow border from strong (high) emphasis badges in V2
  • The edge treatment was an inset box-shadow via --goa-badge-border that Figma does not include
  • Subtle emphasis badges are unaffected, they retain their individual box-shadow tokens

Fixes #3648

Steps needed to test

  1. Run the React playground (npm run serve:prs:react)
  2. Navigate to bugs/3648
  3. Verify strong emphasis badges (all types, medium and large) have no visible inner border/shadow
  4. Verify subtle emphasis badges still show their edge treatment
image

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 10, 2026

Deploy Preview for benji-docs-previews ready!

Name Link
🔨 Latest commit a34d348
🔍 Latest deploy log https://app.netlify.com/projects/benji-docs-previews/deploys/69dffcc7304c2e0008022742
😎 Deploy Preview https://deploy-preview-3801--benji-docs-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@twjeffery twjeffery marked this pull request as ready for review April 13, 2026 15:01
@twjeffery twjeffery marked this pull request as draft April 13, 2026 15:44
@twjeffery twjeffery marked this pull request as ready for review April 13, 2026 17:05
Comment thread apps/prs/react/src/app/app.tsx Outdated
Comment thread libs/web-components/src/components/badge/Badge.svelte
@twjeffery twjeffery force-pushed the tom/badge-refinements branch from a79c438 to 500a8c6 Compare April 14, 2026 20:40
@twjeffery twjeffery requested a review from ArakTaiRoth April 14, 2026 20:42
Copy link
Copy Markdown
Collaborator

@Spark450 Spark450 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified visual treatments are updated.

@twjeffery twjeffery force-pushed the tom/badge-refinements branch 7 times, most recently from dd077cd to a34d348 Compare April 15, 2026 21:01
Remove box-shadow inner border from strong emphasis badges in V2.
Subtle emphasis badges retain their individual box-shadow tokens.
@twjeffery twjeffery force-pushed the tom/badge-refinements branch from a34d348 to b57728e Compare April 28, 2026 03:05
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-28 19:05 UTC

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

Preview removed

All preview folders cleaned from gh-pages branch.

@ArakTaiRoth ArakTaiRoth merged commit 1772ddc into dev Apr 28, 2026
5 checks passed
@ArakTaiRoth ArakTaiRoth deleted the tom/badge-refinements branch April 28, 2026 19:04
@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0-dev.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 7.0.0-dev.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Badge refinements

4 participants