fix(#3630): drawer exit animation, close button alignment, docs updates#3813
Merged
ArakTaiRoth merged 1 commit intodevfrom Apr 28, 2026
Merged
fix(#3630): drawer exit animation, close button alignment, docs updates#3813ArakTaiRoth merged 1 commit intodevfrom
ArakTaiRoth merged 1 commit intodevfrom
Conversation
✅ Deploy Preview for benji-docs-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
Design token dependencyThe drawer content vertical padding fix (16px to 24px) is tracked in a separate design-tokens PR:
|
twjeffery
force-pushed
the
tom/drawer-refinements
branch
2 times, most recently
from
0af2ec8 to
d7a21a7
Compare
twjeffery
force-pushed
the
tom/drawer-refinements
branch
from
d7a21a7 to
1f6e6ab
Compare
ArakTaiRoth
reviewed
Apr 14, 2026
twjeffery
force-pushed
the
tom/drawer-refinements
branch
2 times, most recently
from
45683db to
6a3fe1a
Compare
ArakTaiRoth
reviewed
Apr 15, 2026
bdfranck
reviewed
Apr 15, 2026
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I looked at the changes...
- ✅ The drawer close animation works on left, right, and bottom Drawers
- ✅ The animations use design tokens
- ✅ Docs: The "With actions" example Drawer has a left-aligned button group
- ✅ Docs: The component category is "Structure and Navigation"
Looks good! I just have one small comment about the button.
twjeffery
force-pushed
the
tom/drawer-refinements
branch
2 times, most recently
from
755a2cc to
6f4de1e
Compare
ArakTaiRoth
approved these changes
Apr 22, 2026
twjeffery
force-pushed
the
tom/drawer-refinements
branch
from
6f4de1e to
e9bfa2e
Compare
|
Preview removedAll preview folders cleaned from gh-pages branch. |
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 7.0.0-dev.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 2.0.0-dev.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 5.0.0-dev.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibility: hidden)motion-duration-medium-1,motion-duration-short-4,motion-curve-expressive)alignment="start"on button group (wasend)Fixes #3630
Steps needed to test
npm run serve:prs:react)Screen.Recording.2026-04-13.at.3.35.53.PM.mov