docs(#3746): Add notification panel documentation page#3828
docs(#3746): Add notification panel documentation page#3828
Conversation
✅ Deploy Preview for benji-docs-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
0cfadf4 to
701d01f
Compare
701d01f to
7eb52c2
Compare
7eb52c2 to
58ae35c
Compare
|
Preview links
Built from commit 0e31200. Previews are removed automatically when this PR closes. |
58ae35c to
b5b5f53
Compare
|
@twjeffery I think you need to run |
|
@twjeffery There's no thumbnail added for the "Notification Panel" component |
| popoverContent={ | ||
| <GoabWorkSideNotificationPanel | ||
| heading="Notifications" | ||
| activeTab="urgent" |
There was a problem hiding this comment.
Not sure I fully understand what this activeTab property is supposed to do, so please correct me if I'm wrong. I assumed this would be the default active tab when the notification panel is opened. If that is correct, then it's not working. In WorkSideNotificationPanel.svelte on line 253, the initialTab property is hardcoded to always be Unread, or 1.
There was a problem hiding this comment.
You are right, it is a good catch. I have logged it as a separate bug so it does not hold up this docs PR: #3896
| ref={dropdownRef} | ||
| > | ||
| {configurations.configurations.map((config) => ( | ||
| <goa-dropdown-item key={config.id} value={config.id} label={config.name} /> |
There was a problem hiding this comment.
Why did you remove the key property? It isn't required, but it's how React renders items and becomes a warning if it isn't included. And I see no reason to remove it.
There was a problem hiding this comment.
Good catch - looks like I removed it by mistake, I added it back.
000fa6b to
6b2f611
Compare
6b2f611 to
0096786
Compare
willcodeforcoffee
left a comment
There was a problem hiding this comment.
-
Can we make the side-menu a little shorter? In all three of the examples the workspace is so tall that I had to scroll down to see the notifications. Users will want to see the Notifications right away.
-
There is a weird bug: when I click "Mark all as read" the "Unread" tab background maintains the width even though the item shrank, so it overlaps the "Urgent" tab. It doesn't do this in the Workspace Demo site.
notification_badge_width.mp4
- In the Examples tab the image and "View example" link are broken:
They might need to use `baseUrl`?
- Events and Notification Item Events have an extra line in them?
Co-authored-by: Vanessa Tran <thytran142@icloud.com>
3466552 to
0e31200
Compare
|
Hello @willcodeforcoffee ,
Thank you @willcodeforcoffee |
Summary
previewStyle,previewWrapper) in ARCHITECTURE.mdWhat changed
New component pages:
work-side-notification-panel.mdx— visible page named "Notification Panel"work-side-notification-item.mdx— hidden subcomponent page named "Notification Item"work-side-menu/directory, not their own folder)Configuration preview improvements:
previewStyleandpreviewWrapperoptional fields toComponentConfigurationstypepreviewStyleapplies CSS to the preview container (e.g. background color)previewWrapperwraps the component in layout HTML for the preview only — the code snippet shown to users contains just the component code, not the wrapper. Uses{{slot}}as placeholder.previewStyle: "padding: 0;"to push drawer config so it fills the preview edge-to-edgeExampleDisplay improvement:
Workspace example page:
work-side-notification-panelandwork-side-notification-itemto the components listTest plan
/components/work-side-notification-panel