fix(#3657): use the goa progress component in the temp notification#3831
Open
chrisolsen wants to merge 1 commit intodevfrom
Open
fix(#3657): use the goa progress component in the temp notification#3831chrisolsen wants to merge 1 commit intodevfrom
chrisolsen wants to merge 1 commit intodevfrom
Conversation
❌ Deploy Preview for benji-docs-previews failed.
|
twjeffery
previously approved these changes
Apr 17, 2026
Collaborator
twjeffery
left a comment
twjeffery
left a comment
There was a problem hiding this comment.
@chrisolsen, my PR #3806 touches the same file with some visual changes (shadow, min-heights, action button, mobile wrapping). I'll rebase on top of yours once it merges and handle the goa-linear-progress color and size overrides there so we're not stepping on each other.
chrisolsen
force-pushed
the
chris/3657-temp-notification-progress-bar
branch
from
69383ff to
4208468
Compare
chrisolsen
force-pushed
the
chris/3657-temp-notification-progress-bar
branch
from
4208468 to
ea6bbd1
Compare
ArakTaiRoth
reviewed
Apr 23, 2026
|
|
||
| {#if type === "progress"} | ||
| <progress data-testid="progress" value={progress} max="100" /> | ||
| <goa-linear-progress progress={progress} max="100" percent-visibility="hidden" /> |
Collaborator
There was a problem hiding this comment.
There's no ariaLabel provided for this, so it fails the accessibility criteria
| <goa-linear-progress progress={progress} max="100" percent-visibility="hidden" /> | ||
| {:else if type === "indeterminate"} | ||
| <progress /> | ||
| <goa-linear-progress percent-visibility="hidden" /> |
Collaborator
There was a problem hiding this comment.
There's no ariaLabel provided for this, so it fails the accessibility criteria
|
|
||
| {#if type === "progress"} | ||
| <progress data-testid="progress" value={progress} max="100" /> | ||
| <goa-linear-progress progress={progress} max="100" percent-visibility="hidden" /> |
Collaborator
There was a problem hiding this comment.
There is no max property
ArakTaiRoth
force-pushed
the
chris/3657-temp-notification-progress-bar
branch
from
ea6bbd1 to
2e15444
Compare
ArakTaiRoth
dismissed stale reviews from vanessatran-ddi and twjeffery
Changes were made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
After (the change)
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
Can use the existing prs feature to test this out http://localhost:xxxx/features/2730