Skip to content

chore: set up github pages per pull request#3835

Merged
vanessatran-ddi merged 1 commit intodevfrom
vanessa/3829
Apr 27, 2026
Merged

chore: set up github pages per pull request#3835
vanessatran-ddi merged 1 commit intodevfrom
vanessa/3829

Conversation

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator

Before (the change)

After (the change)

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

@vanessatran-ddi vanessatran-ddi marked this pull request as draft April 16, 2026 23:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-27 15:30 UTC

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

Preview removed

All preview folders cleaned from gh-pages branch.

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/3829 branch 2 times, most recently from 36f8402 to 02f53dd Compare April 20, 2026 16:27
@vanessatran-ddi vanessatran-ddi self-assigned this Apr 20, 2026
@vanessatran-ddi vanessatran-ddi linked an issue Apr 20, 2026 that may be closed by this pull request
@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review April 20, 2026 16:28
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanessatran-ddi I tested the three previews, everything works. Nav links show correctly, subpaths work, docs search loads correctly, and both playgrounds work well

@GovAlta GovAlta deleted a comment from netlify Bot Apr 23, 2026
Copy link
Copy Markdown
Collaborator

@willcodeforcoffee willcodeforcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can't wait to try it out! 😄

@ArakTaiRoth
Copy link
Copy Markdown
Collaborator

@vanessatran-ddi Just a quick question? Would it be possible to modify this to only deploy the paths that need to be deployed based on changes made? If a PR is a docs only PR, then we don't need to deploy Angular and React previews for example, and vice versa. Not a blocker, just a question if we can do something quickly and easily.

@vanessatran-ddi
Copy link
Copy Markdown
Collaborator Author

@vanessatran-ddi Just a quick question? Would it be possible to modify this to only deploy the paths that need to be deployed based on changes made? If a PR is a docs only PR, then we don't need to deploy Angular and React previews for example, and vice versa. Not a blocker, just a question if we can do something quickly and easily.

@ArakTaiRoth yes technically it is possible with this add-on plugin but I don't think it is quick and easy.

  1. Most of our PRs touch the svelte components, so it may affect React and Angular wrapper, so in practice, both React and Angular playgrounds would still need to rebuild on the majority of Prs.
  2. To use the above plugin, I will need to modify the yaml file to split the job, add condition for each deploy step to build dynamically.
  3. The current workflow is simple and predictable - every 3 Prs get 3 links, reviewers always know where to look. Conditional gate may lead to an error if the first commit doesn't touch the Svelte, but the second does and so on ...
  4. For some Copilot bump dependencies, having 3 preview links are a good way to make sure nothing broke across the stack.

We can revisit if gh-pages branch becomes bigger and bigger, but for now I would rather keep this PR simple and ship it. What do you think?

@vanessatran-ddi vanessatran-ddi merged commit 26f2ba2 into dev Apr 27, 2026
5 checks passed
@vanessatran-ddi vanessatran-ddi deleted the vanessa/3829 branch April 27, 2026 15:30
@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.0-dev.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 7.0.0-dev.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 5.0.0-dev.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup Github Preview

5 participants