fix(#3854): Hide empty menu slots for Work Side Menu in Angular#3855
Open
fix(#3854): Hide empty menu slots for Work Side Menu in Angular#3855
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
bdfranck
force-pushed
the
benji/work-side-menu-angular-slot-fix
branch
2 times, most recently
from
d36c4e3 to
09133a7
Compare
bdfranck
force-pushed
the
benji/work-side-menu-angular-slot-fix
branch
from
09133a7 to
69205e0
Compare
|
Preview links
Built from commit 69205e0. Previews are removed automatically when this PR closes. |
twjeffery
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the Angular wrapper which always renders the primary, secondary, and account menus even when they are empty. You can view the change at the following URL:
https://govalta.github.io/ui-components/pr-preview-angular/pr-3855/bugs/3854
Before (the change)
The primary, secondary, and account menus were always rendered in Angular.
After (the change)
The primary, secondary, and account menus are only rendered when you add the corresponding
TemplateRef.