Open
Conversation
bdfranck
changed the title
bdfranck
force-pushed
the
benji/3504-text-button
branch
from
dc6c71e to
c3ce488
Compare
|
Preview links
Built from commit 27a7b63. Previews are removed automatically when this PR closes. |
bdfranck
force-pushed
the
benji/3504-text-button
branch
from
c3ce488 to
1ef29b6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new "text" visual style option to the Button component family (web component + Angular/React typings/docs), and includes PR demo routes to showcase the new variant.
Changes:
- Extend Button
typeto include"text"in the web component and sharedGoabButtonType. - Add v2 CSS styling for
button.v2.text(including destructive/inverse/disabled + compact adjustments). - Update Angular/React wrapper prop docs and add Angular/React PR showcase routes for feature #3504.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/web-components/src/components/button/Button.svelte | Accepts type="text" and adds v2-only CSS for the new text button style. |
| libs/react-components/src/lib/button/button.tsx | Updates prop JSDoc to document the new "text" type. |
| libs/angular-components/src/lib/components/button/button.ts | Updates prop JSDoc to document the new "text" type. |
| libs/common/src/lib/common.ts | Extends GoabButtonType union to include "text". |
| apps/prs/react/src/routes/features/feat3504.tsx | Adds a React demo page showcasing text button variants. |
| apps/prs/react/src/app/routes/features/feat3504-text-button.route.ts | Registers the React demo route in the PR routes manifest. |
| apps/prs/angular/src/routes/features/feat3504-text-button/feat3504.route.json | Adds Angular PR-route metadata for the demo. |
| apps/prs/angular/src/routes/features/feat3504-text-button/feat3504.component.ts | Adds the Angular standalone component for the demo page. |
| apps/prs/angular/src/routes/features/feat3504-text-button/feat3504.component.html | Adds the Angular demo template showcasing text button variants. |
bdfranck
force-pushed
the
benji/3504-text-button
branch
from
1ef29b6 to
1a60dc9
Compare
bdfranck
requested review from
twjeffery,
vanessatran-ddi and
willcodeforcoffee
and removed request for
twjeffery,
vanessatran-ddi and
willcodeforcoffee
bdfranck
force-pushed
the
benji/3504-text-button
branch
from
1a60dc9 to
2498737
Compare
bdfranck
force-pushed
the
benji/3504-text-button
branch
2 times, most recently
from
ce58873 to
236851f
Compare
Collaborator
Author
|
The changes look good in the latest version of Safari... 
|
Collaborator
Author
|
The changes look good in the latest version of Firefox... 
|
Collaborator
Author
|
The changes look good on the latest version of Chrome... 
|
Collaborator
Author
|
It looks good on the latest Safari on iOS... 
|
Collaborator
Author
|
It looks good on the latest version of Chrome on Android... 
|
10 tasks
bdfranck
force-pushed
the
benji/3504-text-button
branch
2 times, most recently
from
68d4dc3 to
d98e767
Compare
Collaborator
Author
|
I've added a non-text button with a "dark" variant to the PR pages to test the console warning. 
|
bdfranck
force-pushed
the
benji/3504-text-button
branch
from
d98e767 to
27a7b63
Compare
willcodeforcoffee
approved these changes
Apr 30, 2026
Collaborator
willcodeforcoffee
left a comment
willcodeforcoffee
left a comment
There was a problem hiding this comment.
Wow! Great job.
I like the transparent background for inverse. The padding on the Inverse threw me off at first, until I realized it was the container.
This looks great! 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new "Text" type to the Button component. It aligns with the current Figma components. It requires the new tokens from GovAlta/design-tokens#156.
It includes the following changes:
LinkButtonin console and JSDocsDecisions
The ticket had differing opinions on the underline so I chose the following approach:
I kept the 100% width for text buttons on a mobile breakpoint.
Let me know if you have any questions or comments about these decisions.
Screenshots