Chore/remove dashboardcomplete#355
Closed
nelly439 wants to merge 3 commits into
Closed
Conversation
Contributor
|
hey @nelly439, thanks for jumping in! closing this pr because the author needs to be assigned to the linked issue (#283) before opening a pr. please comment on the issue requesting assignment, wait to be assigned, then re-raise your pr. this keeps work fairly distributed across contributors. hope to see a revised pr from you soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing in App.tsx uses DashboardLayout from features/dashboard, never DashboardComplete
No barrel exports or lazy imports reference it
Deleted src /app/pages/DashboardComplete.tsx (1566 lines of dead code) and the now-empty src/app/pages/directly
tsc --noEmit passes
closes #283