chore: remove orphaned app/components/landing duplicates (#286)#368
Closed
jd5073356-max wants to merge 1 commit into
Closed
chore: remove orphaned app/components/landing duplicates (#286)#368jd5073356-max wants to merge 1 commit into
jd5073356-max wants to merge 1 commit into
Conversation
src/app/components/landing/Hero.tsx and Navbar.tsx were unreferenced scaffolding. The live landing UI lives in src/features/landing (imported by App.tsx as `../features/landing`, and it has its own Navbar test). Verified there are no importers: grep -rn "app/components/landing" src -> no matches typecheck and build pass, and the src/features/landing tests stay green after removal. Closes Grainlify#286
4 tasks
Contributor
|
hey @jd5073356-max, thanks for jumping in! closing this pr because the author needs to be assigned to the linked issue (#286) before opening a pr. please comment on the issue requesting assignment, wait to be assigned, then re-raise your pr. this keeps work fairly distributed across contributors. hope to see a revised pr from you soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286
What
Removes
src/app/components/landing/Hero.tsxandsrc/app/components/landing/Navbar.tsx. These were orphaned scaffolding that duplicated the landing UI.Why it's safe
The live landing components are under
src/features/landing/(barrel-exported and imported byApp.tsxas../features/landing; the liveNavbarhas its own test there).No importers reference the removed files:
The folder contained only those two files (no index/barrel, no stories).
Verification
npm run typecheck— passes.npm run build— passes.npx vitest run src/features/landing— green (live landing unaffected).Note:
src/app/App.test.tsxhas 2 failing tests (localStorage.clear()is undefined in that file's jsdom setup). They fail onmainas well, independently of this change — this PR only deletes unreferenced files and does not touchAppor its tests.