Skip to content

Remove the unused features/dashboard/Dashboard.tsx and its barrel exp…#374

Closed
madisonsc52-del wants to merge 1 commit into
Grainlify:mainfrom
madisonsc52-del:Remove-the-unused-features/dashboard/Dashboard.tsx-and-its-barrel-export-#285-FIX
Closed

Remove the unused features/dashboard/Dashboard.tsx and its barrel exp…#374
madisonsc52-del wants to merge 1 commit into
Grainlify:mainfrom
madisonsc52-del:Remove-the-unused-features/dashboard/Dashboard.tsx-and-its-barrel-export-#285-FIX

Conversation

@madisonsc52-del

Copy link
Copy Markdown

Findings

  • Dashboard was exported in the dashboard barrel file but never used in the app.
  • The actual routed entry point is DashboardLayout, not Dashboard.
  • Dashboard.tsx was confirmed to be a dead/unused parallel implementation.
  • No active consumers of Dashboard.tsx existed beyond the unused export.

Fix Features

  • Removed dead code:

    • Deleted src/features/dashboard/Dashboard.tsx
  • Updated exports:

    • Barrel file now points to the active dashboard entry (DashboardLayout)
  • Documentation:

    • Cleanup and reasoning recorded in PR_DESCRIPTION.md

Canonical Entry

  • DashboardLayout is now the single, clear dashboard entry point

Security Findings

  • No impact on security

  • Existing protections remain intact:

    • RoleGuard logic unchanged
    • Route-level access control in App.tsx preserved
  • No guarded functionality was affected


Outcome

  • Eliminated redundant dashboard implementation
  • Avoided broken imports or side effects
  • Improved code clarity and maintainability

CLOSE #285

@Jagadeeshftw

Copy link
Copy Markdown
Contributor

hey @madisonsc52-del, thanks for jumping in! closing this pr because the author needs to be assigned to the linked issue (#285) before opening a pr. please comment on the issue requesting assignment, wait to be assigned, then re-raise your pr. this keeps work fairly distributed across contributors. hope to see a revised pr from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the unused features/dashboard/Dashboard.tsx and its barrel export

2 participants