Open
Conversation
Contributor
|
Thanks for this! I missed your changes when I just fixed locally and created the crc.c including fix. The changes look good. |
Contributor
|
Perhaps the README.md section about building the dynamic library should be changed as well as it no longer relies on Qt Creator to build the library? |
Author
|
I have added install / uninstall targets to Makefile. Target will install library to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, just started experimenting with this library and will be using it with Linux(without QT). This pull request includes a new Makefile which should be suitable to build library for Linux.
libsimplemotionv2.so