Add versioning in save methods#442
Open
xingjian-zhang wants to merge 4 commits intoGraph-Learning-Benchmarks:mainfrom
Open
Add versioning in save methods#442xingjian-zhang wants to merge 4 commits intoGraph-Learning-Benchmarks:mainfrom
xingjian-zhang wants to merge 4 commits intoGraph-Learning-Benchmarks:mainfrom
Conversation
jiaqima
reviewed
May 4, 2023
Contributor
jiaqima
left a comment
jiaqima
left a comment
There was a problem hiding this comment.
Let's discuss about it in our meeting.
gli/io.py
Outdated
| val_ratio, test_ratio, | ||
| num_samples) | ||
| if latest_supported_ver is None: | ||
| raise ValueError("The latest supported version of the metadata.json " |
Contributor
There was a problem hiding this comment.
I'm a little hesitant to mandate the user to fill in a version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add versioning in
save_*()methodsRelated Issue
#406
Motivation and Context
We want metadata.json and task.json to have version information.
In the future, we may want to implement
How Has This Been Tested?
Tested on my own machine
Screenshots (if appropriate):