fix: show user-friendly message for network errors#446
Open
amaanq wants to merge 1 commit intoGrapheneOS:mainfrom
Open
fix: show user-friendly message for network errors#446amaanq wants to merge 1 commit intoGrapheneOS:mainfrom
amaanq wants to merge 1 commit intoGrapheneOS:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, network errors display raw Java exceptions to users (e.g.,
java.net.UnknownHostException: Unable to resolve host "apps.grapheneos.org": No address associated with hostname). This could be presented better to users.Solution
If a given exception is a known network exception, we don't append the error details to the message.
I've tested this on a generic x86_64 emulator, now network errors look like this for me: