Modernise GifTranscoder JNI files#192
Open
mikomikotaishi wants to merge 2 commits into
Open
Conversation
Author
|
@m4pl @RankoR @thestinger I'd like to request a PR review (I do not have access to assign reviewers) |
RankoR
suggested changes
Jul 12, 2026
RankoR
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution.
It's good in general, but could you please do these adjustments?
- Update the PR description and commit message to explicitly mention the x86_64 signed-char undefined behavior and color-corruption fix
- Add a regression test using color channels above 0x7f. An end-to-end test that transcodes the small 4×2 fixture and checks the resulting two pixels would catch the old implementation
- Keep the functional fix in a separate commit from the mechanical modernization
Author
|
Where would you like the test to go? |
Contributor
|
@mikomikotaishi you can add something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following in the native JNI parts of
GifTranscoder:constexprfunctions and constants where possible[[nodiscard]]attributes, to explicitly highlight when a function call's return goes unusednoexceptspecifiers(T)withstatic_cast<T>andreinterpret_cast<T>NULLwithnullptrtypedefwith ausingalias= defaultint[4]withstd::array<int, 4>::timespecand::clock_gettime()withstd::chrono::steady_clockGifFilesCloser