Desktop: Fix drag followed by a click causing a double click

[he1senbrg]

Before

drag-click-before.mp4

After

drag-click-after.mp4

Closes #3714

[timon-schelling]

I think an easier and cleaner solution would be resetting both up_ and down_count whenever xy_delta is to big. down position is already in the record and should not be duplicated.

[he1senbrg]

@timon-schelling I might be wrong, but from what I understood the last time a value is stored in position would be when a click was released, right? And when the next click happens within the conditions it registers as a double click. So, even if we reset up_ and down_count wouldn't the next click still register as double as the previous one was single (either via reset or because of drag)?

[timon-schelling]

I would need to spend more than 2 min looking at the code, but from what I remember it should be possible to split up and down positions and use both of them to figure out the xy delta with each and abort the double click when either the down or up position is to far (fine to add that to the record).

[Keavon]

Marking as draft while awaiting changes.

[he1senbrg]

@timon-schelling Sorry for the delay. Can i remove position from ClickRecord and add down_position and up_position to it so that these can be individually tracked?

[he1senbrg]

@timon-schelling Could you please review the changes

[Keavon]

I'd like to give this a QA test before merging.

[timon-schelling]

@Keavon ok, I think now I'm fine with the patch.