Skip to content

Add Path node differential edit summary widget, and store imported SVG content in that VectorModification struct#4036

Merged
Keavon merged 4 commits intomasterfrom
path-node-vector-modification
Apr 22, 2026
Merged

Add Path node differential edit summary widget, and store imported SVG content in that VectorModification struct#4036
Keavon merged 4 commits intomasterfrom
path-node-vector-modification

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 22, 2026

No description provided.

@Keavon Keavon changed the title Path node vector modification Add Path node differential edit summary widget, and store imported SVG content in that VectorModification struct Apr 22, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions the Path node from storing geometry as a Table to using VectorModification, including migration logic for existing documents. It also introduces UI components to display a summary of these differential edits in the properties panel. Feedback was provided regarding code duplication and potential performance inefficiencies in the summary calculation logic within vector_modification.rs, suggesting a refactor to consolidate the counting logic and reduce allocations.

Comment thread node-graph/libraries/vector-types/src/vector/vector_modification.rs Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@Keavon Keavon merged commit c2e1208 into master Apr 22, 2026
11 checks passed
@Keavon Keavon deleted the path-node-vector-modification branch April 22, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant