Add unit tests for MessageData and DebugMessageTree in utility_types.rs#4049
Open
yuvraj-kolkar17 wants to merge 3 commits intoGraphiteEditor:masterfrom
Open
Add unit tests for MessageData and DebugMessageTree in utility_types.rs#4049yuvraj-kolkar17 wants to merge 3 commits intoGraphiteEditor:masterfrom
yuvraj-kolkar17 wants to merge 3 commits intoGraphiteEditor:masterfrom
Conversation
Signed-off-by: Yuvraj Kolkar <kolkaryuvraj2@gmail.com>
yuvraj-kolkar17
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive unit test suite for the MessageData and DebugMessageTree structures in editor/src/utility_types.rs. The tests cover object instantiation, field updates, and nested variant handling. Feedback was provided to rename a misleading test case and to strengthen assertions by verifying entire collections rather than individual elements, ensuring better data integrity in the tests.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Signed-off-by: Yuvraj Kolkar <kolkaryuvraj2@gmail.com>
Author
|
PTAL @TrueDoctor @Keavon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added unit tests for the
MessageDataandDebugMessageTreestructs ineditor/src/utility_types.rs.Part of #3936
Changes
#[cfg(test)]test module ineditor/src/utility_types.rsMessageDataandDebugMessageTreeTest Results
How to Verify
cargo test utility_typesAI Assistance
Claude Sonnet 4.6
Some parts of the unit tests were written with the help of AI tool.