Fix CI lint: drop unused ledgers import + duplicate torchvision import#223
Merged
Conversation
`eca9e25` removed the `hp = ledgers.get_hyperparams()` call in the ws-classification example but left the now-unused `from weightslab.backend import ledgers` import, tripping ruff F401 in CI. Also drop the exact-duplicate `from torchvision import datasets, transforms` line (ruff F811). Both `datasets` and `transforms` remain used. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the ruff
F401that currently failscode-qualityCI on every branch (the lint job scans the whole./weightslabtree).eca9e25removed thehp = ledgers.get_hyperparams()call inws-classification/main.pybut leftfrom weightslab.backend import ledgers→ unused import (F401).from torchvision import datasets, transformsline (F811). Bothdatasetsandtransformsremain used.Two-line change; unblocks CI for all open PRs (e.g. #221).
🤖 Generated with Claude Code