Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Jan 24, 2026

  • Add ring of slaying
  • Add cave crawlers, rockslugs, cockatrice, basilisk, pyrefiends, jellies, turoth, kurasks & aquanites
  • Fix test item def dependency
  • Fix combat impacts
  • Fix poison immunity
  • Fix emerald bolts (e) spec
  • Add accuracy_roll = false, projectile_origin_x/y to combat definitions
  • Fix poison being able to kill unkillable npcs
  • Fix unequipping on equipment screen

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

Qodana Community for JVM

5 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 5

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 35.75758% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.14%. Comparing base (330cd3f) to head (f267d02).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ntent/area/fremennik_province/rellekka/Rockslug.kt 13.79% 24 Missing and 1 partial ⚠️
...lin/content/skill/magic/jewellery/RingOfSlaying.kt 10.00% 18 Missing ⚠️
.../main/kotlin/content/entity/effect/toxin/Poison.kt 52.00% 1 Missing and 11 partials ⚠️
...mennik_province/rellekka/FremennikSlayerDungeon.kt 67.74% 2 Missing and 8 partials ⚠️
...voidps/engine/data/definition/CombatDefinitions.kt 0.00% 9 Missing ⚠️
...ntent/area/fremennik_province/rellekka/Aquanite.kt 30.76% 9 Missing ⚠️
...me/src/main/kotlin/content/entity/combat/Target.kt 16.66% 4 Missing and 1 partial ⚠️
...regs/voidps/engine/data/config/CombatDefinition.kt 0.00% 3 Missing ⚠️
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 25.00% 0 Missing and 3 partials ⚠️
.../kotlin/content/entity/player/effect/Dragonfire.kt 57.14% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
Files with missing lines Coverage Δ
...main/kotlin/content/entity/proj/ShootProjectile.kt 58.08% <100.00%> (+0.31%) ⬆️
...ain/kotlin/content/skill/constitution/drink/Tea.kt 69.04% <100.00%> (ø)
...in/content/entity/player/equip/EquipmentBonuses.kt 23.42% <0.00%> (ø)
game/src/main/kotlin/content/skill/ranged/Ammo.kt 47.69% <0.00%> (ø)
...c/main/kotlin/content/skill/slayer/EnchantedGem.kt 9.43% <0.00%> (ø)
...ent/area/fremennik_province/rellekka/Cockatrice.kt 50.00% <50.00%> (ø)
...rc/main/kotlin/content/entity/combat/hit/Damage.kt 63.21% <60.00%> (+0.42%) ⬆️
...main/kotlin/content/entity/effect/toxin/Disease.kt 16.92% <0.00%> (ø)
...regs/voidps/engine/data/config/CombatDefinition.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/content/entity/npc/combat/Attack.kt 50.36% <25.00%> (+0.36%) ⬆️
... and 8 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #851      +/-   ##
============================================
+ Coverage     37.12%   37.14%   +0.02%     
- Complexity     7247     7255       +8     
============================================
  Files          1494     1499       +5     
  Lines         58957    59061     +104     
  Branches      14862    14898      +36     
============================================
+ Hits          21886    21937      +51     
- Misses        32123    32166      +43     
- Partials       4948     4958      +10     
Components Coverage Δ
Content 34.36% <38.56%> (+0.05%) ⬆️
Engine 42.78% <0.00%> (-0.04%) ⬇️
Network 60.93% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 671e906 into main Jan 24, 2026
5 checks passed
@GregHib GregHib deleted the frem-slayer-dungeon branch January 24, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants