Preroll Ranged Ingredients on Recipe Start (1.21) - #5048
Open
DilithiumThoride wants to merge 10 commits into
Open
Preroll Ranged Ingredients on Recipe Start (1.21)#5048DilithiumThoride wants to merge 10 commits into
DilithiumThoride wants to merge 10 commits into
Conversation
DilithiumThoride
added
1.21
type: refactor
This was referenced Jul 2, 2026
DilithiumThoride
force-pushed
the
dt/ranged-prerolls-1.21
branch
from
July 23, 2026 04:27
9eceede to
4503331
Compare
DilithiumThoride
added
the
Ignore Version Sync
github-actions
Bot
added
Tests: Passed
github-actions
Bot
added
Tests: Failed
github-actions
Bot
added
Tests: Passed
DilithiumThoride
marked this pull request as ready for review
July 24, 2026 05:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#5015 + #5051 ported to 1.21
Implementation Details
NeoForge SizedIngredient/SizedFluidIngredient require an extra level of unwrapping versus 1.20 GTM's inhouse SI/FI. This extra unwrapping forces the IRanged checks to be done a few layers further down (and at times in slightly less clean ways because my attempts at writing a mixin to unify SI/SFI under a shared ISized failed).
AI Usage
Outcome
Ranged Ingredients preroll their values before recipe start.
Fixes #4326 and re-enables all Ranged Ingredient Tests
How Was This Tested
Added several more automated tests to account for the new behaviors
Additional Information
Flagged "Ignore Version Sync" as it is the version sync complement to #5015.