Better data- and worldgen handling - #5096
Merged
gustovafing merged 11 commits intoJul 25, 2026
Merged
Conversation
2 tasks
gustovafing
requested changes
Jul 25, 2026
gustovafing
added
type: refactor
gustovafing
reviewed
Jul 25, 2026
gustovafing
requested changes
Jul 25, 2026
gustovafing
approved these changes
Jul 25, 2026
gustovafing
added
ignore changelog
gustovafing
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clean up
IMO having these in the same PR is fine as both are mostly conversion to deferred registration.
Implementation Details
Un-janked feature type registration (removed the deferred registries from
GTRegistriesand the static registration from a few miscallaneous classes that used them)Converted
DungeonLootLoaderinto a couple deferred registersAI Usage
Outcome
WAY, WAY cleaner handling of chest loot addition and feature placement registration
How Was This Tested
ran game, opened chests
Additional Information
copied the GLM type from Neoforge because Forge doesn't have any builtin ones for whatever reason
Potential Compatibility Issues
Anyone still using the removed placement modifiers will have to copy them. IDK that anyone is using them, though, as GT addons don't tend to have custom worldgen features (especially with special placement rules).